Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Exclude cluster from termination for Windows investigation #6008

Merged
merged 1 commit into from
Apr 9, 2024
Merged

ci: Exclude cluster from termination for Windows investigation #6008

merged 1 commit into from
Apr 9, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Apr 9, 2024

Fixes #N/A

Description

  • Exclude soak-periodic-2785632730 from being terminated for an investigation

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 9, 2024 22:13
@engedaam engedaam requested a review from jonathan-innis April 9, 2024 22:13
@netlify Netlify
Copy link

netlify bot commented Apr 9, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit c5c1dd5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6615bda857ded4000793547f
😎 Deploy Preview https://deploy-preview-6008--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@engedaam engedaam enabled auto-merge (squash) April 9, 2024 22:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8622962828

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.261%
Totals Coverage Status
Change from base Build 8622323079: 0.0%
Covered Lines: 5333
Relevant Lines: 6483
💛 - Coveralls

jmdeal
jmdeal approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 5cdcca4 into aws:main Apr 9, 2024
16 checks passed
@engedaam engedaam deleted the exclude_cluster branch April 9, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@jonathan-innis jonathan-innis Awaiting requested review from jonathan-innis jonathan-innis is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jmdeal