Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Support GetProfileName() through Instance profile interface #6003

Merged
merged 1 commit into from
Apr 9, 2024
Merged

chore: Support GetProfileName() through Instance profile interface #6003

merged 1 commit into from
Apr 9, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Supports the call to GetInstanceProfile as part of the Instance Profile provider interface

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner April 9, 2024 03:38
@jonathan-innis jonathan-innis requested a review from ljosyula April 9, 2024 03:38
@jonathan-innis jonathan-innis enabled auto-merge (squash) April 9, 2024 03:38
@netlify Netlify
Copy link

netlify bot commented Apr 9, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8d9c101
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6614b849596a6c0008292b2d

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8609989448

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.261%
Totals Coverage Status
Change from base Build 8608647925: 0.02%
Covered Lines: 5333
Relevant Lines: 6483
💛 - Coveralls

jmdeal
jmdeal approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 3fbaf66 into aws:main Apr 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@ljosyula ljosyula Awaiting requested review from ljosyula ljosyula is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @jmdeal