test: Expect drift to occur within 1 minute #5999

engedaam · 2024-04-08T16:41:20Z

Fixes #N/A

Description

Update testing to validate that drift is occurring within a 1 minute window

How was this change tested?

/karpenter snapshot

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2024-04-08T16:41:39Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`cc02848`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/66141e333ec99500088b70e7

engedaam

/karpenter snapshot

netlify · 2024-04-08T16:42:08Z

✅ Deploy Preview for karpenter-docs-prod ready!

Name	Link
🔨 Latest commit	`cbe7079`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/662605dae9dbe00008dc4013
😎 Deploy Preview	https://deploy-preview-5999--karpenter-docs-prod.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-04-08T16:43:25Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-23e797ca4685ceca6945559a6d27f5639c201527.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-23e797ca4685ceca6945559a6d27f5639c201527" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

coveralls · 2024-04-08T16:46:18Z

Pull Request Test Coverage Report for Build 8779632236

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.978%

Totals
Change from base Build 8769944868:	0.0%
Covered Lines:	5395
Relevant Lines:	6581

💛 - Coveralls

engedaam

/karpenter snapshot

engedaam

/karpenter snapshot

github-actions · 2024-04-16T10:09:30Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-39e2ab2cb8f73bb2519496104406b859d52cef0d.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-39e2ab2cb8f73bb2519496104406b859d52cef0d" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

github-actions · 2024-04-16T10:12:14Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-6a5182d0173eb195a8add6c8fbd16d99eb278667.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-6a5182d0173eb195a8add6c8fbd16d99eb278667" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

/karpenter snapshot

github-actions · 2024-04-22T06:41:42Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-cbe70790c9c1276f83565e97f8496fa8ec95fff6.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-cbe70790c9c1276f83565e97f8496fa8ec95fff6" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis · 2024-04-23T18:28:06Z

test/pkg/environment/common/expectations.go

@@ -693,7 +693,7 @@ func (env *Environment) EventuallyExpectDrifted(nodeClaims ...*corev1beta1.NodeC
 			g.Expect(env.Client.Get(env, client.ObjectKeyFromObject(nc), nc)).To(Succeed())
 			g.Expect(nc.StatusConditions().GetCondition(corev1beta1.Drifted).IsTrue()).To(BeTrue())
 		}
-	}).Should(Succeed())
+	}).WithTimeout(1 * time.Minute).Should(Succeed())


Is this supposed to be 15s or 1m?

It should be 1 min

github-actions · 2024-05-08T12:04:43Z

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

github-actions · 2024-05-30T12:04:44Z

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

engedaam requested a review from a team as a code owner April 8, 2024 16:41

engedaam requested a review from ellistarn April 8, 2024 16:41

engedaam commented Apr 8, 2024

View reviewed changes

engedaam force-pushed the short-reqeue-drift-test branch from 23e797c to 39e2ab2 Compare April 16, 2024 10:07

engedaam changed the title ~~test: Expect drift to occur within 5 seconds~~ test: Expect drift to occur within 15 seconds Apr 16, 2024

engedaam commented Apr 16, 2024

View reviewed changes

engedaam force-pushed the short-reqeue-drift-test branch from 39e2ab2 to 6a5182d Compare April 16, 2024 10:08

engedaam commented Apr 16, 2024

View reviewed changes

engedaam force-pushed the short-reqeue-drift-test branch from 6a5182d to 1f967cb Compare April 22, 2024 06:38

Expect drift to occur within 5 seconds

cbe7079

engedaam force-pushed the short-reqeue-drift-test branch from 1f967cb to cbe7079 Compare April 22, 2024 06:38

engedaam commented Apr 22, 2024

View reviewed changes

jonathan-innis reviewed Apr 23, 2024

View reviewed changes

engedaam changed the title ~~test: Expect drift to occur within 15 seconds~~ test: Expect drift to occur within 1 minute Apr 23, 2024

github-actions bot added the lifecycle/stale label May 8, 2024

engedaam removed the lifecycle/stale label May 15, 2024

github-actions bot added the lifecycle/stale label May 30, 2024

github-actions bot added the lifecycle/closed label Jun 13, 2024

github-actions bot closed this Jun 13, 2024

engedaam deleted the short-reqeue-drift-test branch July 5, 2024 07:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Expect drift to occur within 1 minute #5999

test: Expect drift to occur within 1 minute #5999

engedaam commented Apr 8, 2024 •

edited

Loading

netlify bot commented Apr 8, 2024 •

edited

Loading

engedaam left a comment

netlify bot commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024

coveralls commented Apr 8, 2024 •

edited

Loading

engedaam left a comment

engedaam left a comment

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

engedaam left a comment

github-actions bot commented Apr 22, 2024

jonathan-innis Apr 23, 2024

engedaam Apr 23, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 30, 2024

test: Expect drift to occur within 1 minute #5999

test: Expect drift to occur within 1 minute #5999

Conversation

engedaam commented Apr 8, 2024 • edited Loading

netlify bot commented Apr 8, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

engedaam left a comment

Choose a reason for hiding this comment

netlify bot commented Apr 8, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod ready!

github-actions bot commented Apr 8, 2024

coveralls commented Apr 8, 2024 • edited Loading

Pull Request Test Coverage Report for Build 8779632236

Details

💛 - Coveralls

engedaam left a comment

Choose a reason for hiding this comment

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 22, 2024

jonathan-innis Apr 23, 2024

Choose a reason for hiding this comment

engedaam Apr 23, 2024

Choose a reason for hiding this comment

github-actions bot commented May 8, 2024

github-actions bot commented May 30, 2024

engedaam commented Apr 8, 2024 •

edited

Loading

netlify bot commented Apr 8, 2024 •

edited

Loading

netlify bot commented Apr 8, 2024 •

edited

Loading

coveralls commented Apr 8, 2024 •

edited

Loading