Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs changes in getting-started-with-karpenter doc to fix #5677 #5989

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

santosh-at-github
Copy link
Contributor

@santosh-at-github santosh-at-github commented Apr 5, 2024

Fixes #5677

Description
The Karpenter pods fails to come up when the helm command provided in the documentation used for deploying Karpenter pods on Fargate. To fix this Cluster launch command and Karpenter installation helm commands needs slight modification. This PR will create separate tabs for Cluster launch command and for Karpenter installation commands for Node Group as well as Fargate.

How was this change tested?
In my test account EKS deployment and document changes were tested locally with "hugo server -D" command.

Does this change impact docs?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@santosh-at-github santosh-at-github requested a review from a team as a code owner April 5, 2024 07:48
@santosh-at-github santosh-at-github requested a review from njtran April 5, 2024 07:48
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 49205e0
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6610cd7a6bed780008fa9e93
😎 Deploy Preview https://deploy-preview-5989--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-49205e05a04335b4284e41cefd4be5c22b4fc1a3.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-49205e05a04335b4284e41cefd4be5c22b4fc1a3" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8578673920

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.243%

Totals Coverage Status
Change from base Build 8562831109: 0.0%
Covered Lines: 5331
Relevant Lines: 6482

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 0af6b01 into aws:main Apr 8, 2024
22 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started with Karpenter
3 participants