Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add image pull canary #5987

Merged
merged 4 commits into from
Apr 9, 2024
Merged

ci: add image pull canary #5987

merged 4 commits into from
Apr 9, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Apr 4, 2024

Fixes #N/A

Description
Adds a periodic workflow to Karpenter's CI suite which checks artifact availability for the last 4 minor releases. This will give us an early warning if the images have been removed or if a release failed to publish.

How was this change tested?
Workflow run in fork

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner April 4, 2024 20:45
@jmdeal jmdeal requested a review from ellistarn April 4, 2024 20:45
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit e96fae5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6615a7281623c90008f46caf

@jmdeal jmdeal force-pushed the image-canary branch 2 times, most recently from b3a67b3 to 305c4a1 Compare April 4, 2024 20:57
@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 8621991931

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.246%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8619869367: -0.02%
Covered Lines: 5332
Relevant Lines: 6483

💛 - Coveralls

@jmdeal jmdeal force-pushed the image-canary branch 9 times, most recently from 409c5a9 to 4b5b5f1 Compare April 5, 2024 23:45
@jmdeal
Copy link
Contributor Author

jmdeal commented Apr 6, 2024

Discussed offline, moving over to using the GH cli and just pulling the last 10 releases. This removes the need for the go script to parse the paginated output and handle the release filtering, simplifying the setup.

.github/workflows/image-canary.yaml Outdated Show resolved Hide resolved
.github/workflows/image-canary.yaml Outdated Show resolved Hide resolved
.github/workflows/image-canary.yaml Outdated Show resolved Hide resolved
.github/workflows/image-canary.yaml Outdated Show resolved Hide resolved
@jmdeal jmdeal force-pushed the image-canary branch 2 times, most recently from 7b1e25c to 92df8be Compare April 8, 2024 22:53
@jmdeal jmdeal force-pushed the image-canary branch 7 times, most recently from 7323394 to ec9d5f2 Compare April 9, 2024 20:28
@jmdeal jmdeal force-pushed the image-canary branch 2 times, most recently from e737b71 to 118d0ac Compare April 9, 2024 20:36
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit c101fb2 into aws:main Apr 9, 2024
17 checks passed
@jmdeal jmdeal deleted the image-canary branch May 9, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants