-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add image pull canary #5987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jmdeal
force-pushed
the
image-canary
branch
2 times, most recently
from
April 4, 2024 20:57
b3a67b3
to
305c4a1
Compare
Pull Request Test Coverage Report for Build 8621991931Details
💛 - Coveralls |
engedaam
reviewed
Apr 5, 2024
engedaam
reviewed
Apr 5, 2024
engedaam
reviewed
Apr 5, 2024
jmdeal
force-pushed
the
image-canary
branch
9 times, most recently
from
April 5, 2024 23:45
409c5a9
to
4b5b5f1
Compare
Discussed offline, moving over to using the GH cli and just pulling the last 10 releases. This removes the need for the go script to parse the paginated output and handle the release filtering, simplifying the setup. |
jmdeal
force-pushed
the
image-canary
branch
2 times, most recently
from
April 8, 2024 22:53
7b1e25c
to
92df8be
Compare
jmdeal
force-pushed
the
image-canary
branch
7 times, most recently
from
April 9, 2024 20:28
7323394
to
ec9d5f2
Compare
jmdeal
force-pushed
the
image-canary
branch
2 times, most recently
from
April 9, 2024 20:36
e737b71
to
118d0ac
Compare
jonathan-innis
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Adds a periodic workflow to Karpenter's CI suite which checks artifact availability for the last 4 minor releases. This will give us an early warning if the images have been removed or if a release failed to publish.
How was this change tested?
Workflow run in fork
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.