Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Only run CI actions in karpenter-provider-aws repo #5983

Merged
merged 2 commits into from
Apr 4, 2024
Merged

chore: Only run CI actions in karpenter-provider-aws repo #5983

merged 2 commits into from
Apr 4, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Apr 4, 2024

Fixes #N/A

Description

  • We should not allow unnecessary CI runs in forked repos

How was this change tested?

  • In a forked account

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 4, 2024 16:42
@engedaam engedaam requested a review from jmdeal April 4, 2024 16:42
@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 7281111
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/660f0296803350000842487b

jonathan-innis
jonathan-innis approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) April 4, 2024 19:45
@engedaam engedaam merged commit 67a88b7 into aws:main Apr 4, 2024
16 checks passed
@engedaam engedaam deleted the only-run-in-the-branch branch April 4, 2024 19:55
@coveralls
Copy link

coveralls commented Apr 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8560383065

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.181%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8560380243: -0.02%
Covered Lines: 5327
Relevant Lines: 6482
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jonathan-innis