Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add unit cache tests for subnets #5978

Merged
merged 1 commit into from
Apr 8, 2024
Merged

test: Add unit cache tests for subnets #5978

merged 1 commit into from
Apr 8, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Apr 3, 2024

Fixes #N/A

Description

  • Adding testing to validate the subnets cache is caching expected values

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 3, 2024 17:51
@engedaam engedaam requested a review from tzneal April 3, 2024 17:51
@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit c2e1155
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66103d4b503e340008625d03

@engedaam engedaam marked this pull request as draft April 3, 2024 18:10
@engedaam engedaam force-pushed the cache-subnet-test branch from 1a2ac5f to 86e7a8c Compare April 3, 2024 18:37
@engedaam engedaam marked this pull request as ready for review April 3, 2024 18:39
@coveralls
Copy link

coveralls commented Apr 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8573906715

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.243%
Totals Coverage Status
Change from base Build 8562831109: 0.0%
Covered Lines: 5331
Relevant Lines: 6482
💛 - Coveralls

@engedaam engedaam force-pushed the cache-subnet-test branch from 86e7a8c to fc8007b Compare April 5, 2024 16:37
jmdeal
jmdeal reviewed Apr 5, 2024
View reviewed changes
pkg/providers/subnet/suite_test.go Outdated Show resolved Hide resolved
pkg/providers/subnet/suite_test.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the cache-subnet-test branch from fc8007b to c2e1155 Compare April 5, 2024 18:04
jmdeal
jmdeal approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal
Copy link
Contributor

jmdeal commented Apr 5, 2024

I don't think I need to revoke my approval for this, consider it non-blocking, but I'm wondering if we should also test the combination of different filter types.

@engedaam
Copy link
Contributor Author

engedaam commented Apr 8, 2024

Planning on adding the combination of different filter types as a follow-up

@engedaam engedaam merged commit f8bfd1e into aws:main Apr 8, 2024
17 checks passed
@engedaam engedaam deleted the cache-subnet-test branch April 8, 2024 16:22
@engedaam engedaam mentioned this pull request Apr 12, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jmdeal