Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use "${KarpenterNodeRole.Arn}" in policy definition #5976

Merged
merged 1 commit into from
Apr 8, 2024
Merged

chore: Use "${KarpenterNodeRole.Arn}" in policy definition #5976

merged 1 commit into from
Apr 8, 2024

Conversation

ruzickap
Copy link
Contributor

@ruzickap ruzickap commented Apr 3, 2024

Description

Use reference to ${KarpenterNodeRole.Arn} for "Sid": "AllowPassingInstanceRole" in CloudFormation (like it is already done in case of "Sid": "AllowInterruptionQueueActions" definition)

How was this change tested?

Deploy CloudFormation...

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruzickap ruzickap requested a review from a team as a code owner April 3, 2024 14:19
@ruzickap ruzickap requested a review from ellistarn April 3, 2024 14:19
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 262dcf5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66138b7c066a9a0008bbd887
😎 Deploy Preview https://deploy-preview-5976--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathan-innis jonathan-innis enabled auto-merge (squash) April 8, 2024 06:10
@coveralls
Copy link

coveralls commented Apr 8, 2024

Pull Request Test Coverage Report for Build 8595432947

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.243%

Totals Coverage Status
Change from base Build 8562831109: 0.0%
Covered Lines: 5331
Relevant Lines: 6482

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Nice catch and improvement!

@jonathan-innis jonathan-innis merged commit 282b0b4 into aws:main Apr 8, 2024
16 checks passed
@ruzickap ruzickap deleted the policy-iam-role branch April 8, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants