Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Slack Notification Step #5962

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Fix syntax error in slack notification step

How was this change tested?
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner April 2, 2024 19:20
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 7bb4ddb
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/660c5a96cdcd030008355f0c

Copy link
Contributor Author

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8528276613

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.197%

Totals Coverage Status
Change from base Build 8526723247: 0.0%
Covered Lines: 5328
Relevant Lines: 6482

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-7bb4ddb336e7429343814694d5b8ea0ac10f6ac8.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-7bb4ddb336e7429343814694d5b8ea0ac10f6ac8" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 5122901 into aws:main Apr 2, 2024
19 of 29 checks passed
@jigisha620 jigisha620 deleted the feat-slack-message2 branch April 24, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants