Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use $Default LT version #595

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Conversation

JacobGabrielson
Copy link
Contributor

@JacobGabrielson JacobGabrielson commented Aug 3, 2021

Issue, if available:

#434

Description of changes:

WIP to hard-code to $Default launch template version rather than allow specifying it (which runs in to a whole host of problems).

Tested that nodes come up properly with and without the node selector on the Provisioner.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@geoffcline
Copy link
Contributor

May I label this with docs to make sure the docs get updated when this lands? /gdc

@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 903c177

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/611564b025afad000787afc0

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More or less LGTM. I was struggling to come up with any interesting validation to do. One comment about id -> name.

@JacobGabrielson JacobGabrielson marked this pull request as ready for review August 12, 2021 00:24
@JacobGabrielson JacobGabrielson changed the title [WIP] Initial pass at hard-coding $Default LT version Always use $Default LT version Aug 12, 2021
@JacobGabrielson
Copy link
Contributor Author

May I label this with docs to make sure the docs get updated when this lands? /gdc

Sure!

ellistarn
ellistarn previously approved these changes Aug 12, 2021
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@geoffcline geoffcline added the documentation Improvements or additions to documentation label Aug 12, 2021
@ellistarn ellistarn merged commit 0fd3139 into aws:main Aug 12, 2021
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants