-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use $Default LT version #595
Conversation
May I label this with docs to make sure the docs get updated when this lands? /gdc |
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 903c177 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/611564b025afad000787afc0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More or less LGTM. I was struggling to come up with any interesting validation to do. One comment about id -> name.
89222df
to
e21bfb6
Compare
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
e21bfb6
to
903c177
Compare
Issue, if available:
#434
Description of changes:
WIP to hard-code to
$Default
launch template version rather than allow specifying it (which runs in to a whole host of problems).Tested that nodes come up properly with and without the node selector on the Provisioner.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.