Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix error checking for the node class controller #5948

Merged
merged 1 commit into from
Apr 1, 2024
Merged

chore: Fix error checking for the node class controller #5948

merged 1 commit into from
Apr 1, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • fix Error handling for the node class controller

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner March 31, 2024 23:34
@engedaam engedaam requested a review from ljosyula March 31, 2024 23:34
@netlify Netlify
Copy link

netlify bot commented Mar 31, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 9a4c98e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/660ae494f3fcb600083394f2

@engedaam engedaam changed the title chore: Fix Error checking for the node class controller chore: Fix error checking for the node class controller Mar 31, 2024
@coveralls
Copy link

coveralls commented Mar 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8510815811

Details

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 82.285%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclass/controller.go 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/nodeclass/controller.go 3 74.87%
Totals Coverage Status
Change from base Build 8510045992: -0.03%
Covered Lines: 5351
Relevant Lines: 6503
💛 - Coveralls

@engedaam engedaam enabled auto-merge (squash) April 1, 2024 02:06
jonathan-innis
jonathan-innis approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit f967e70 into aws:main Apr 1, 2024
17 checks passed
@engedaam engedaam deleted the fix-err branch April 4, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@ljosyula ljosyula Awaiting requested review from ljosyula ljosyula is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jonathan-innis