Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherrypick(v0.32): fix: include resource.Quantity in launch template cache key #5933

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Mar 25, 2024

Fixes #N/A

Description
Cherry pick of #5882. Drops the capacity type caching since #4911 isn't included in v0.32.x.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner March 25, 2024 23:48
@jmdeal jmdeal requested a review from ljosyula March 25, 2024 23:48
@jmdeal jmdeal changed the title fix: include resource.Quantity in launch template cache key cherrypick(v0.32): fix: include resource.Quantity in launch template cache key Mar 25, 2024
@coveralls
Copy link

coveralls commented Mar 25, 2024

Pull Request Test Coverage Report for Build 8428535093

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 82.456%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.63%
Totals Coverage Status
Change from base Build 8284609386: 0.05%
Covered Lines: 6218
Relevant Lines: 7541

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit a5112f1 into aws:release-v0.32.x Mar 26, 2024
8 checks passed
@jmdeal jmdeal deleted the release-v0.32.x branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants