-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to select instance by EBS Maximum Bandwidth #5925
feat: Add ability to select instance by EBS Maximum Bandwidth #5925
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me! Just one comment.
3a0d889
to
2eb78f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, optional. It would just be good to know if this is a consistent value that we can rely-on, and, if so, where is the constant that we can point to for it?
2eb78f5
to
b95802d
Compare
Pull Request Test Coverage Report for Build 8955652337Details
💛 - Coveralls |
61612a3
to
029742a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
@NetanelK Looks like it needs a rebase, but otherwise, we should be good to merge here. |
029742a
to
50e4139
Compare
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
50e4139
to
8fb1f6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #5905
Description
This PR adds the ability to select instances by EBS maximum bandwidth limit, by using the label
karpenter.k8s.aws/instance-ebs-bandwidth
How was this change tested?
make presubmit
, Added EBS Info to codegen.Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.