test: Add unit test to validate the instancetype cache #5917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
engedaam
force-pushed
the
add-instancetype-cache-test
branch
3 times, most recently
from
890fe97 to
7cdc5ac
Compare
Pull Request Test Coverage Report for Build 8635855489Details
💛 - Coveralls |
engedaam
force-pushed
the
add-instancetype-cache-test
branch
6 times, most recently
from
bd72ea8 to
bd387e8
Compare
engedaam
force-pushed
the
add-instancetype-cache-test
branch
3 times, most recently
from
f20cb17 to
7b915b1
Compare
njtran
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Is there some sort of reflection we can do to make sure that each of the values that are added into the InstanceTypesProvider.List() has a table entry? It seems like this does the job, but there's no test that would fail if someone just finds + replaces all the instances of the List() function definition to add a new parameter.
engedaam
force-pushed
the
add-instancetype-cache-test
branch
3 times, most recently
from
2f1ac4e to
66f4c0f
Compare
engedaam
force-pushed
the
add-instancetype-cache-test
branch
5 times, most recently
from
77fe86d to
2b2dde5
Compare
engedaam
force-pushed
the
add-instancetype-cache-test
branch
from
2b2dde5 to
05d8d34
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Add unit test to validate the instancetype cache will give different set of instance type based on input
The tested value currently are
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.