Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reword AMI tasks to options #5815

Merged
merged 5 commits into from
Mar 9, 2024
Merged

Conversation

chrisnegus
Copy link
Member

Description: Updated the Managing AMIs docs to change the name identifying the "tasks" to "options" instead. Also backported the update to all versions from v0.32 and higher.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chrisnegus chrisnegus requested a review from a team as a code owner March 8, 2024 22:00
@chrisnegus chrisnegus requested a review from bwagner5 March 8, 2024 22:00
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ec8604f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65ecf5f0840e3700070c2464
😎 Deploy Preview https://deploy-preview-5815--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Mar 8, 2024

Pull Request Test Coverage Report for Build 8217976274

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.727%

Totals Coverage Status
Change from base Build 8211149400: 0.0%
Covered Lines: 5302
Relevant Lines: 6409

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the amitaskoptions branch 2 times, most recently from f376764 to 90c7a70 Compare March 9, 2024 23:25
@jonathan-innis jonathan-innis changed the title Reword AMI tasks to options docs: Reword AMI tasks to options Mar 9, 2024
@jonathan-innis jonathan-innis force-pushed the amitaskoptions branch 2 times, most recently from c509f3a to 6be5fde Compare March 9, 2024 23:41
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) March 9, 2024 23:51
@jonathan-innis jonathan-innis merged commit cdde4e2 into aws:main Mar 9, 2024
17 checks passed
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Mar 12, 2024
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Mar 27, 2024
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants