-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Reword AMI tasks to options #5815
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 8217976274Details
💛 - Coveralls |
jonathan-innis
force-pushed
the
amitaskoptions
branch
2 times, most recently
from
March 9, 2024 23:25
f376764
to
90c7a70
Compare
jonathan-innis
changed the title
Reword AMI tasks to options
docs: Reword AMI tasks to options
Mar 9, 2024
jonathan-innis
force-pushed
the
amitaskoptions
branch
2 times, most recently
from
March 9, 2024 23:41
c509f3a
to
6be5fde
Compare
jonathan-innis
force-pushed
the
amitaskoptions
branch
from
March 9, 2024 23:51
6be5fde
to
ec8604f
Compare
jonathan-innis
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
engedaam
pushed a commit
to engedaam/karpenter
that referenced
this pull request
Mar 12, 2024
Co-authored-by: Jonathan Innis <[email protected]>
engedaam
pushed a commit
to engedaam/karpenter
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Jonathan Innis <[email protected]>
engedaam
pushed a commit
to engedaam/karpenter
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Jonathan Innis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Updated the Managing AMIs docs to change the name identifying the "tasks" to "options" instead. Also backported the update to all versions from v0.32 and higher.
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.