Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix topology zone list value quote issue in docs #5808

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

BingchenLi
Copy link
Contributor

@BingchenLi BingchenLi commented Mar 8, 2024

Fixes #N/A

Description
This change is to fix the quote mistake in topology zone value list in docs.
Different zone values need to be separate strings, thus should be quoted separately in the list.

How was this change tested?
This only includes the docs change.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • [] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@BingchenLi BingchenLi requested a review from a team as a code owner March 8, 2024 13:58
@BingchenLi BingchenLi requested a review from jmdeal March 8, 2024 13:58
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 9f73e39
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65eb19822a1d2800089fdb75
😎 Deploy Preview https://deploy-preview-5808--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thanks for catching this!

@jonathan-innis jonathan-innis enabled auto-merge (squash) March 8, 2024 19:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8204340784

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.662%

Totals Coverage Status
Change from base Build 8195391472: 0.0%
Covered Lines: 5278
Relevant Lines: 6385

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 950be07 into aws:main Mar 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants