Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump Karpenter version to include Drift hash Versioning for NodePool #5801

Merged
merged 1 commit into from
Mar 7, 2024
Merged

chore: Bump Karpenter version to include Drift hash Versioning for NodePool #5801

merged 1 commit into from
Mar 7, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Mar 7, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner March 7, 2024 20:13
@engedaam engedaam requested a review from ljosyula March 7, 2024 20:13
@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit bc58ccf
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65ea2f893fcdef0008a3ae11

@engedaam engedaam changed the title chore: Bump Karpenter version chore: Bump Karpenter version to include Drift hash Versioning for NodePool Mar 7, 2024
jonathan-innis
jonathan-innis previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) March 7, 2024 20:44
@engedaam engedaam force-pushed the bump-ver branch 2 times, most recently from d9f5720 to e59d20b Compare March 7, 2024 21:12
@coveralls
Copy link

coveralls commented Mar 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8194953065

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 82.662%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8167043202: -0.01%
Covered Lines: 5278
Relevant Lines: 6385
💛 - Coveralls

jigisha620
jigisha620 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 108bdf5 into aws:main Mar 7, 2024
16 checks passed
@engedaam engedaam deleted the bump-ver branch March 7, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigisha620 jigisha620 jigisha620 approved these changes

@jonathan-innis jonathan-innis jonathan-innis left review comments

@ljosyula ljosyula Awaiting requested review from ljosyula ljosyula is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@engedaam @coveralls @jonathan-innis @jigisha620