Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add kubeReserved default note #5788

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Mar 5, 2024

Fixes #5676
Description
Adds a note about how kubeReserved defaults effect ephemeral storage calculation

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner March 5, 2024 19:32
@jmdeal jmdeal requested a review from njtran March 5, 2024 19:32
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ce6ac37
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65e797bfbc4d0b00089f109a
😎 Deploy Preview https://deploy-preview-5788--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 8163650664

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.634%

Totals Coverage Status
Change from base Build 8152324329: 0.0%
Covered Lines: 5258
Relevant Lines: 6363

💛 - Coveralls

@jmdeal jmdeal force-pushed the kube-reserved-defaults-docs branch from 216c1c9 to 72f451c Compare March 5, 2024 20:08
@jmdeal jmdeal force-pushed the kube-reserved-defaults-docs branch from 72f451c to 1ab1a22 Compare March 5, 2024 21:36
engedaam
engedaam previously approved these changes Mar 5, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 68e736d into aws:main Mar 5, 2024
17 checks passed
@jmdeal jmdeal deleted the kube-reserved-defaults-docs branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karpenter cannot provision node with same instance type previously used by cluster-autoscaler
3 participants