Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add instance type offering availability to metrics #5771

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Mar 3, 2024

Fixes #2596

Description

Adds a metric to our CloudProvider metrics to track the offering availability over time. This also updates the karpenter_cloudprovider_instance_type_price_estimate metric to be fired when the offerings are created, rather than when the prices are updated in the pricing provider. This also changes the name to include the word "offering" to be karpenter_cloudprovider_instance_type_offering_price_estimate to align with karpenter_cloudprovider_instance_type_offering_available

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner March 3, 2024 08:13
@jonathan-innis jonathan-innis requested a review from jmdeal March 3, 2024 08:13
Copy link

netlify bot commented Mar 3, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 1190499
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65e638ff195b070007858e4b
😎 Deploy Preview https://deploy-preview-5771--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathan-innis jonathan-innis force-pushed the add-instance-type-offering-available branch from 9de6644 to bec33c6 Compare March 3, 2024 08:14
@jonathan-innis jonathan-innis force-pushed the add-instance-type-offering-available branch 4 times, most recently from da49495 to 7ea1ea9 Compare March 3, 2024 08:20
@coveralls
Copy link

coveralls commented Mar 3, 2024

Pull Request Test Coverage Report for Build 8147053298

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 82.639%

Totals Coverage Status
Change from base Build 8146289356: -0.02%
Covered Lines: 5255
Relevant Lines: 6359

💛 - Coveralls

@jonathan-innis jonathan-innis enabled auto-merge (squash) March 3, 2024 08:22
@jonathan-innis jonathan-innis force-pushed the add-instance-type-offering-available branch 5 times, most recently from 5758520 to 548f9f5 Compare March 3, 2024 08:41
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-548f9f5e0e89bf9b14d6cf6326a037c80d7121b6.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-548f9f5e0e89bf9b14d6cf6326a037c80d7121b6" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis jonathan-innis force-pushed the add-instance-type-offering-available branch from 548f9f5 to 612e685 Compare March 4, 2024 21:10
@jonathan-innis jonathan-innis force-pushed the add-instance-type-offering-available branch from 612e685 to 1190499 Compare March 4, 2024 21:11
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 0cc6779 into aws:main Mar 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Cloud Provider Offering Availability as Metrics
3 participants