-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add instance type offering availability to metrics #5771
chore: Add instance type offering availability to metrics #5771
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9de6644
to
bec33c6
Compare
da49495
to
7ea1ea9
Compare
Pull Request Test Coverage Report for Build 8147053298Details
💛 - Coveralls |
5758520
to
548f9f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
548f9f5
to
612e685
Compare
612e685
to
1190499
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #2596
Description
Adds a metric to our CloudProvider metrics to track the offering availability over time. This also updates the
karpenter_cloudprovider_instance_type_price_estimate
metric to be fired when the offerings are created, rather than when the prices are updated in the pricing provider. This also changes the name to include the word "offering" to bekarpenter_cloudprovider_instance_type_offering_price_estimate
to align withkarpenter_cloudprovider_instance_type_offering_available
How was this change tested?
make presubmit
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.