Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance AMI task docs after review #5749

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Conversation

chrisnegus
Copy link
Member

Description
Updated the Managing AMIs docs after a formal review.

Does this change impact docs?

  • Yes, PR includes docs updates
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chrisnegus chrisnegus requested a review from a team as a code owner February 29, 2024 16:43
@chrisnegus chrisnegus requested a review from tzneal February 29, 2024 16:43
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit af5d297
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65e1fbd71d0fba000810c344
😎 Deploy Preview https://deploy-preview-5749--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Feb 29, 2024

Pull Request Test Coverage Report for Build 8113843942

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.642%

Totals Coverage Status
Change from base Build 8089078497: 0.02%
Covered Lines: 5256
Relevant Lines: 6360

💛 - Coveralls

@jmdeal
Copy link
Contributor

jmdeal commented Feb 29, 2024

Looking good! A couple of small comments, I only left them on one of the copies, but they of course apply to both. I'm also wondering if we should include this in the v0.33 and v0.32 docs as well, just with a disclaimer in the disruption budgets task that users will need to upgrade to v0.34. Originally I was thinking we could maybe include it with Task 3 dropped but if anything including it gives users a good example of why they should upgrade.

@chrisnegus chrisnegus requested a review from njtran February 29, 2024 17:36
website/content/en/preview/tasks/amitasks.md Outdated Show resolved Hide resolved
website/content/en/preview/tasks/amitasks.md Outdated Show resolved Hide resolved
website/content/en/preview/tasks/amitasks.md Outdated Show resolved Hide resolved
website/content/en/preview/tasks/amitasks.md Outdated Show resolved Hide resolved
@chrisnegus
Copy link
Member Author

chrisnegus commented Mar 1, 2024

Looking good! A couple of small comments, I only left them on one of the copies, but they of course apply to both. I'm also wondering if we should include this in the v0.33 and v0.32 docs as well, just with a disclaimer in the disruption budgets task that users will need to upgrade to v0.34. Originally I was thinking we could maybe include it with Task 3 dropped but if anything including it gives users a good example of why they should upgrade.

I totally agree with that. I've worked on docs projects where we only published one version, but noted when a feature was added when we described it for exactly the reason you mentioned. Can we merge this, then I can follow up with another PR to update and copy the content to v0.32 and v0.33?

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems fine to take as a follow-up. LGTM 🚀

@jmdeal jmdeal merged commit c7c0ec2 into aws:main Mar 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants