Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix pod eviction docs #5701

Merged
merged 3 commits into from
Feb 28, 2024
Merged

docs: fix pod eviction docs #5701

merged 3 commits into from
Feb 28, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Feb 20, 2024

Fixes #N/A

Description
The docs were incorrect after changes to our pod filtering logic here: kubernetes-sigs/karpenter#789

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner February 20, 2024 22:34
@njtran njtran requested a review from engedaam February 20, 2024 22:34
Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 323438f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65df68ded721eb00089c0485
😎 Deploy Preview https://deploy-preview-5701--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 8084350551

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 32 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 82.595%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 8 94.56%
pkg/providers/instance/instance.go 24 89.79%
Totals Coverage Status
Change from base Build 7974046797: 0.08%
Covered Lines: 5054
Relevant Lines: 6119

💛 - Coveralls

engedaam
engedaam previously approved these changes Feb 20, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit fb2a474 into aws:main Feb 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants