Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: karpenter core version bump and docgen #5697

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

Bryce-Soghigian
Copy link
Contributor

@Bryce-Soghigian Bryce-Soghigian commented Feb 20, 2024

Fixes #N/A

Description
Bumping core and metrics, looks like preview already contains cluster state.

How was this change tested?
NA
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 673b5dc
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65d5567a26bbc50008113c61
😎 Deploy Preview https://deploy-preview-5697--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review February 20, 2024 10:16
@Bryce-Soghigian Bryce-Soghigian requested a review from a team as a code owner February 20, 2024 10:16
@Bryce-Soghigian
Copy link
Contributor Author

We can /hold until the change gets released, just figured we should add docs pr for feature to be "complete"

@Bryce-Soghigian Bryce-Soghigian changed the title docs: adding cluster_state metrics docs docs: adding cluster_state metrics Feb 20, 2024
@Bryce-Soghigian Bryce-Soghigian changed the title docs: adding cluster_state metrics docs: adding cluster_state metrics for node_count and synced Feb 20, 2024
@Bryce-Soghigian Bryce-Soghigian changed the title docs: adding cluster_state metrics for node_count and synced chore: karpenter core version bump and docgen Feb 21, 2024
@Bryce-Soghigian
Copy link
Contributor Author

@jonathan-innis thanks for sharing the commands! Seems you already fixed this in the past 3 days when i pushed the pr https://github.com/aws/karpenter-provider-aws/pull/5673/files, but happy to just bump and update the metrics

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7982774816

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.497%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 7974046797: -0.02%
Covered Lines: 5015
Relevant Lines: 6079

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 050e74f into aws:main Feb 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants