-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add minValues flexibility to the NodePool requirement. #5640
Conversation
This reverts commit 7944e94.
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits. LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This reverts commit 7c0559c.
Pull Request Test Coverage Report for Build 7997021303Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
This PR adds
minValues
flexibility to the NodePool requirement. The new NodePool requirement will be represented as:minValues
represents the minimum number of unique values that needs to be considered for a particular requirement. So, this value ensures that the scheduler creates NodeClaims meeting this new requirement.This PR has a dependency on another PR (Karpenter-sigs) that I am going to send out shortly (Update: Here is the PR: https://github.com/nikmohan123/karpenter/pull/1/files). Most of the changes in this PR is about changing the requirement struct to a new one that has flexibility of
minValues
in it. The main changes are related to lifting the restrictions/truncation logic that we have for the list of InstanceTypes that we send today to CreateFleet and also bypassing the logic that filters the expensive instanceTypes. This is to ensure that theminValues
flexibility of the requirement is not compromised.More details in: kubernetes-sigs/karpenter#966
How was this change tested?
Functional tests added.
Manually tested as well.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.