Update getting started eksctl.yaml #563
Conversation
Switching from self managed node group to managed node group. This could help customers in the future if they keep a cluster around a while and want to update the EKS version. Also specified the EKS version because depending on which version of `eksctl` the user has it may deploy a different version. I would use 1.21 but the official `eksctl` with 1.21 support isn't out yet. 1.20 has been covered for a while and gets us a semi-new version of a cluster to avoid unknown issues.
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 6b0afc9 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61019a9167b61c00089e64e6 😎 Browse the preview: https://deploy-preview-563--karpenter-docs-prod.netlify.app |
| @@ -4,7 +4,8 @@ kind: ClusterConfig | |||
| metadata: | |||
| name: ${CLUSTER_NAME} | |||
| region: ${AWS_DEFAULT_REGION} | |||
| nodeGroups: | |||
| version: "1.20" | |||
There was a problem hiding this comment.
I was going to set this version, but I realized that it will cause our doc to go stale quickly. It's a bit tricky -- perhaps we could add a note/step upgrade eksctl on mac/linux to ensure the latest version?
There was a problem hiding this comment.
Unless you think we should just maintain this?
There was a problem hiding this comment.
The docs will need to be versioned at some point so we're going to have to maintain versions either way. Some companies will have really old versions of EKS and we'll want to keep karpenter docs for them and maybe in the future we need to stop karpenter users from using the latest EKS (for whatever reason).
Depending on the users shell having a comment in a command block can cause an error. My zsh errored and didn't run the commands. Removing the extra comments to avoid that issue.
Will also need to be versioned with new releases.
|
If you want to merge this in with .3 release we'll have to update the helm chart release too. |
|
W/ current docs, we will need to hold off on updating until the release is cut. |
Switching from self managed node group to managed node group. This could help customers in the future if they keep a cluster around a while and want to update the EKS version.
Also specified the EKS version because depending on which version of
eksctlthe user has it may deploy a different version. I would use 1.21 but the officialeksctlwith 1.21 support isn't out yet. 1.20 has been covered for a while and gets us a semi-new version of a cluster to avoid unknown issues.Issue, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.