Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cache Instance Types for both AWSNodeTemplate and EC2NodeClass #5629

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Feb 8, 2024

Fixes #5578

Description
When a AWSNodeTemplate and EC2NodeClass are contain identical values in the configurations, Karpenter would treat the set of instance types as the same even if they have different requirements. This is a problem as the v1beta1 well-known labels and v1alpha5 well-known labels have a one label difference in that being karpenter.k8s.aws/instance-pods. So if the cached instance types were from a AWSNodeTemplate would have karpenter.k8s.aws/instance-pods in the requirement set for its list of instancetypes, which will result in a Compatibility check with NodeClaims invalid for all the instancetypes. This will prevent Karpenter from launching any nodes.

How was this change tested?

  • Manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner February 8, 2024 00:51
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7823255847

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.355%

Totals Coverage Status
Change from base Build 7719733856: 0.0%
Covered Lines: 6175
Relevant Lines: 7498

💛 - Coveralls

@engedaam engedaam merged commit 46343b8 into aws:release-v0.32.x Feb 8, 2024
8 checks passed
@engedaam engedaam deleted the instance-type-fix branch March 7, 2024 20:09
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants