fix: Cache Instance Types for both AWSNodeTemplate and EC2NodeClass #5629
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5578
Description
When a AWSNodeTemplate and EC2NodeClass are contain identical values in the configurations, Karpenter would treat the set of instance types as the same even if they have different requirements. This is a problem as the v1beta1 well-known labels and v1alpha5 well-known labels have a one label difference in that being karpenter.k8s.aws/instance-pods. So if the cached instance types were from a AWSNodeTemplate would have karpenter.k8s.aws/instance-pods in the requirement set for its list of instancetypes, which will result in a Compatibility check with NodeClaims invalid for all the instancetypes. This will prevent Karpenter from launching any nodes.
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.