Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add budgets replacement tests #5602

Merged
merged 5 commits into from
Feb 5, 2024
Merged

test: add budgets replacement tests #5602

merged 5 commits into from
Feb 5, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Feb 5, 2024

Fixes #N/A

Description
Adds tests to test concurrent disruption replacements

How was this change tested?
make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner February 5, 2024 20:23
@njtran njtran requested a review from jmdeal February 5, 2024 20:23
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b56495c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65c15ea8e856050008faec26

@coveralls
Copy link

coveralls commented Feb 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7791569557

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.627%
Totals Coverage Status
Change from base Build 7763246327: 0.0%
Covered Lines: 5008
Relevant Lines: 6061
💛 - Coveralls

njtran
njtran commented Feb 5, 2024
View reviewed changes
Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-daff7473866cd98b724d05608a664985717a295c.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

njtran
njtran commented Feb 5, 2024
View reviewed changes
Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-e1b19bdf6b1d5823c1d02a044eed381752b3788c.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

jonathan-innis
jonathan-innis previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

test/suites/drift/suite_test.go Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran enabled auto-merge (squash) February 5, 2024 22:19
@njtran njtran merged commit ce9f728 into aws:main Feb 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njtran @coveralls @jonathan-innis