Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix drift/expiration test flakes #5601

Merged
merged 2 commits into from
Feb 5, 2024
Merged

test: fix drift/expiration test flakes #5601

merged 2 commits into from
Feb 5, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Feb 5, 2024

Fixes #N/A

Description
Fix some tests with disruption that had unnecessary cordon logic causing replacement nodes when we wanted delete actions only.

How was this change tested?
TEST_SUITE="Expiration" make e2etests
TEST_SUITE="Drift" make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner February 5, 2024 19:13
@njtran njtran requested a review from ellistarn February 5, 2024 19:13
Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit db328f4
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65c1637e137a8600082918af

@coveralls
Copy link

coveralls commented Feb 5, 2024

Pull Request Test Coverage Report for Build 7791788317

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.61%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 7763246327: -0.02%
Covered Lines: 5007
Relevant Lines: 6061

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-4234f0e906dbca83fa35ac51245d1131a2507bda.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

engedaam
engedaam previously approved these changes Feb 5, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 354f692 into aws:main Feb 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants