Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update old static AMI for k8s 1.29+ for drift #5575

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Jan 31, 2024

Fixes #N/A

Description
Pods fail to schedule to the old static AMI used to trigger drift in the affected test. They failed with the following error:

time=2024-01-31T01:19:06Z type=Warning reason=FailedCreatePodSandBox from=kubelet message=Failed to create pod sandbox: rpc error: code = Unknown desc = failed to set up sandbox container "e7834551c5c56e7eeb7af397b425c5fa403867fd9d40827fcf903db48183c6d5" network for pod "spikealder-40-pcqkph2ugu-74bbf85989-rhdvd": networkPlugin cni failed to set up pod "spikealder-40-pcqkph2ugu-74bbf85989-rhdvd_default" network: unsupported CNI result version "1.0.0"

Triggering off of a newer AMI for 1.29+ resolves this error. The original AMI is still used for previous versions since we still run these tests in our compatibility matrix for k8s 1.23.

How was this change tested?
make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner January 31, 2024 23:59
@jmdeal jmdeal requested a review from bwagner5 January 31, 2024 23:59
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 0b7d131
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65baded5477e29000822b415
😎 Deploy Preview https://deploy-preview-5575--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7733986825

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.66%

Totals Coverage Status
Change from base Build 7732972443: 0.0%
Covered Lines: 5010
Relevant Lines: 6061

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 8312ba5 into aws:main Feb 1, 2024
16 checks passed
@jmdeal jmdeal deleted the fix-drift-test branch May 9, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants