Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning for Ubuntu AMI family on k8s 1.29+ #5573

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Jan 31, 2024

Fixes #N/A

Description
Adds a warning to the upgrade docs for Karpenter v0.34.x about the Ubuntu AMI family. More details can be found in #5572.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner January 31, 2024 21:21
@jmdeal jmdeal requested a review from jigisha620 January 31, 2024 21:21
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 50d8124
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65bac2ed7e5dd40008c2ffba
😎 Deploy Preview https://deploy-preview-5573--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jan 31, 2024

Pull Request Test Coverage Report for Build 7732912685

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.676%

Totals Coverage Status
Change from base Build 7719422505: 0.0%
Covered Lines: 5011
Relevant Lines: 6061

💛 - Coveralls

@jmdeal jmdeal force-pushed the ubuntu-note branch 2 times, most recently from bbe41b5 to e93db37 Compare January 31, 2024 21:46
jonathan-innis
jonathan-innis previously approved these changes Jan 31, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes it a little more clear that if you didn't make any changes and upgraded, you are going to get stuck

website/content/en/preview/upgrading/compatibility.md Outdated Show resolved Hide resolved
@jmdeal jmdeal enabled auto-merge (squash) January 31, 2024 21:58
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 925884e into aws:main Jan 31, 2024
16 checks passed
@jmdeal jmdeal deleted the ubuntu-note branch May 9, 2024 23:47
@jmdeal jmdeal restored the ubuntu-note branch May 9, 2024 23:47
@jmdeal jmdeal deleted the ubuntu-note branch May 9, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants