-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reduce indentation for servicemonitor endpoints #5571
fix: Reduce indentation for servicemonitor endpoints #5571
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Seems odd that the first item in the list was indented properly, but the second wasn't. Can you post the installation command you used to set these endpoint configs? |
The first set of items is not part of the indent loop. The second are. I'll get you installation information tomorrow, but for the moment, you can see the issue in a helm playground https://helm-playground.com/#t=N7C0AIEsDMDoDUCGAbArgUwM60%2BgTgG6QDG6AsgPYB2kALhXrOlYgEbLoAm4oAvrwChEAB0jx8mSNQBc4ALbU6DSFQDmsYg3QVsmuQHoCARgEBrFZ1kBlfEVKUa9PALnpaiTonfSB4cC1dZU0Q8YWZafF9-RFdMYURSWWgKCgE49GIfPwCseNIbDmInLL95L2IACwA5GKwS0p5wZNS-XELiqL85coqAGTZ0ZEx60tYQqOZOYQoVWmHOxum8WlkK2lphUFdaPBJMBb942grZfW3d4n2GkAgAdzoK8AQUDGxcQhJyRScmKimZqi0ADC1GgkFU4H4B3AN3A9AAmjFkE9wAAffwWcLgABskME1zA4EmeIEsOJfF4QA&v=M4UwTgbglgxiCyB7AdlALosAuAUAAjxGQEMAjAGxABMs80wBXEfQ5KgB0SmTQGEUAZlADmuAgFo8nMGloB3EKQAWiRAGtxAWxD1YwFgXbE0S2gHptumMCA |
Ah no you're totally right, I missed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request Test Coverage Report for Build 7728576834Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Fixes #N/A
Description
The indentation for
serviceMonitor
endpoints was set too high, causing bad yaml to be renderedHow was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.