Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: init container e2e tests #5516

Merged
merged 3 commits into from
Feb 2, 2024
Merged

test: init container e2e tests #5516

merged 3 commits into from
Feb 2, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Jan 23, 2024 •
edited
Loading

Fixes #N/A

Description
This PR adds some minimal end-to-end tests for init container resource computation in light of this upstream PR: kubernetes-sigs/karpenter#569.

How was this change tested?
/karpenter snapshot + local make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal added the blocked Unable to make progress due to some dependency label Jan 23, 2024
@jmdeal jmdeal requested a review from a team as a code owner January 23, 2024 18:27
@jmdeal jmdeal requested a review from jigisha620 January 23, 2024 18:27
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit ca6c513
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65bd6afe92e7840007dce617

@jmdeal
Copy link
Contributor Author

jmdeal commented Jan 23, 2024

Blocked by some changes that need to be changed in the upstream PR to support specifying init container images: kubernetes-sigs/karpenter#569 (comment)

@jmdeal jmdeal force-pushed the init-containers-e2e branch 2 times, most recently from 99aa5b9 to 0aff539 Compare January 23, 2024 18:34
@coveralls
Copy link

coveralls commented Jan 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7762202728

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.66%
Totals Coverage Status
Change from base Build 7760839612: 0.0%
Covered Lines: 5010
Relevant Lines: 6061
💛 - Coveralls

@jmdeal jmdeal force-pushed the init-containers-e2e branch 7 times, most recently from 7f94b72 to c1d9f4d Compare January 29, 2024 05:09
jmdeal
jmdeal commented Jan 29, 2024
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-c1d9f4d0a8436f6b4e8ece1aa22b1caf15384f69.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jmdeal jmdeal force-pushed the init-containers-e2e branch 2 times, most recently from de09884 to 992a221 Compare January 31, 2024 02:28
jmdeal
jmdeal commented Jan 31, 2024
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-992a2210b8f08baae9bc083855dda8c796fe0e09.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jmdeal jmdeal force-pushed the init-containers-e2e branch from 992a221 to 1db9a12 Compare January 31, 2024 18:00
jmdeal
jmdeal commented Jan 31, 2024
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-1db9a1277afebb1f83367417a4d07fe60f2d5505.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jmdeal jmdeal force-pushed the init-containers-e2e branch 3 times, most recently from dc777ff to a529c3e Compare February 1, 2024 22:01
jmdeal
jmdeal commented Feb 1, 2024
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jmdeal jmdeal force-pushed the init-containers-e2e branch from f35421a to 22d5a18 Compare February 1, 2024 23:30
jmdeal
jmdeal commented Feb 1, 2024
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-961ce2b5a85cc2a4933f7ecf19b0b9943407cdda.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jmdeal jmdeal force-pushed the init-containers-e2e branch from 961ce2b to 97e267a Compare February 2, 2024 00:25
jmdeal
jmdeal commented Feb 2, 2024
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-97e267a3695c64a6a0d03fe06c6b4c0ce957a1ea.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

jmdeal
jmdeal commented Feb 2, 2024
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-563af446d0cd2ff3825784901d4401cf7d8ced46.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jmdeal jmdeal force-pushed the init-containers-e2e branch from 563af44 to 21a35cd Compare February 2, 2024 18:33
@jmdeal jmdeal removed the blocked Unable to make progress due to some dependency label Feb 2, 2024
@jmdeal jmdeal force-pushed the init-containers-e2e branch from 9a62119 to ca6c513 Compare February 2, 2024 22:21
jonathan-innis
jonathan-innis approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 7786b5d into aws:main Feb 2, 2024
16 checks passed
@jmdeal jmdeal deleted the init-containers-e2e branch May 9, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jigisha620 jigisha620 Awaiting requested review from jigisha620 jigisha620 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmdeal @coveralls @jonathan-innis