Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Incorrect information during v1beta1-migration.md to official document version 0.32.x #5488

Merged
merged 1 commit into from
Jan 18, 2024
Merged

docs: Incorrect information during v1beta1-migration.md to official document version 0.32.x #5488

merged 1 commit into from
Jan 18, 2024

Conversation

xgro
Copy link
Contributor

@xgro xgro commented Jan 18, 2024

Fixes #N/A

Description
incorrect information during v1beta1-migration to official document version 0.32.x

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Incorrect information during v1beta1-migration.md to official document version 0.32.x
@xgro xgro requested a review from a team as a code owner January 18, 2024 05:04
@xgro xgro requested a review from jonathan-innis January 18, 2024 05:04
Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 34805b8
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65a8b172cb43b100089929cd
😎 Deploy Preview https://deploy-preview-5488--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xgro
Copy link
Contributor Author

xgro commented Jan 18, 2024

#5475 (review)
Thank you for the PR's advice. @jonathan-innis
I close the existing pr and created a new pr for the main branch.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@jonathan-innis jonathan-innis enabled auto-merge (squash) January 18, 2024 08:12
@jonathan-innis jonathan-innis merged commit 72f1703 into aws:main Jan 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants