Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add E2E testing for fully blocking budgets with and without schedule #5484

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Jan 17, 2024

Fixes #N/A

Description

This change adds testing for ensuring that fully blocking budgets (both with and without a schedule) will block particular disruption actions either all of the time or at specified times during the day as dictated by the schedule.

Note: Consolidation tests to come later when I add testing for consolidation budgets in a follow-on

How was this change tested?

/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 17, 2024 06:21
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit e6d0406
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65a8104989d1e1000830b198

@jonathan-innis jonathan-innis force-pushed the add-blocking-budgets-e2e branch from d0d0912 to 31248be Compare January 17, 2024 06:26
@coveralls
Copy link

coveralls commented Jan 17, 2024

Pull Request Test Coverage Report for Build 7559624097

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.547%

Totals Coverage Status
Change from base Build 7559461936: 0.0%
Covered Lines: 4952
Relevant Lines: 5999

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the add-blocking-budgets-e2e branch 2 times, most recently from d98877b to 22f3fd8 Compare January 17, 2024 06:32
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-22f3fd86a5fe2650926d9b9cd38ca140cb7d43f4.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jonathan-innis jonathan-innis force-pushed the add-blocking-budgets-e2e branch from 22f3fd8 to 6b1dca5 Compare January 17, 2024 06:48
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-6b1dca5551f2a611c1cdce4ed89d810804928c37.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jonathan-innis jonathan-innis force-pushed the add-blocking-budgets-e2e branch from 6b1dca5 to ce979c9 Compare January 17, 2024 08:54
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-ce979c937ba93a1bc3975ca58d36ced3ef050419.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jonathan-innis jonathan-innis enabled auto-merge (squash) January 17, 2024 09:16
@jonathan-innis jonathan-innis force-pushed the add-blocking-budgets-e2e branch from ce979c9 to e6d0406 Compare January 17, 2024 17:37
@jonathan-innis jonathan-innis merged commit a285991 into aws:main Jan 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants