Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add testing for PodDisrputionBudgets in E2E testing #5480

Merged

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Add testing for ensuring PodDisruptionBudgets block drift and expiration in E2E testing

How was this change tested?

/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 16, 2024 08:43
@jonathan-innis jonathan-innis requested a review from tzneal January 16, 2024 08:43
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 121d366
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65a804cb908efc0008684ca4

@coveralls
Copy link

coveralls commented Jan 16, 2024

Pull Request Test Coverage Report for Build 7559023537

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.547%

Totals Coverage Status
Change from base Build 7549038164: 0.0%
Covered Lines: 4952
Relevant Lines: 5999

💛 - Coveralls

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-7fa7634adf9ea9b37a81a081763874b507a9211f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jonathan-innis jonathan-innis force-pushed the add-pod-disruption-e2e-testing branch from 7fa7634 to a3c11cb Compare January 16, 2024 08:52
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-a3c11cb80f36d49262be42cfe1d49d355b1cadf3.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jonathan-innis jonathan-innis force-pushed the add-pod-disruption-e2e-testing branch from a3c11cb to accd07c Compare January 16, 2024 08:54
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-accd07cdd242878dc8a0aadc69dea3bd85485f61.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jonathan-innis jonathan-innis force-pushed the add-pod-disruption-e2e-testing branch from accd07c to 91a7249 Compare January 16, 2024 08:57
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-91a7249d95b66e9cc88fa70c6178c3a60c013b78.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jonathan-innis jonathan-innis force-pushed the add-pod-disruption-e2e-testing branch from 91a7249 to 7c9ef79 Compare January 16, 2024 23:21
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

njtran
njtran previously approved these changes Jan 16, 2024
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-7c9ef79880210b2c2a5398d68b7ffe2664adb921.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jonathan-innis jonathan-innis force-pushed the add-pod-disruption-e2e-testing branch from 113046e to 121d366 Compare January 17, 2024 16:48
@jonathan-innis jonathan-innis merged commit 529f243 into aws:main Jan 17, 2024
14 checks passed
@jonathan-innis jonathan-innis deleted the add-pod-disruption-e2e-testing branch January 17, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants