-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hash volume size quantity value as a string #5454
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 8457681220Details
💛 - Coveralls |
This change is blocked until we have the ability to version the hashes that we are using to evaluate drift since this would be a breaking change to the existing hash versioning mechanism since a previously unconsidered field would now get hashed with a value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
84f3589
to
7d52a31
Compare
7d52a31
to
f507ab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
75b797a
to
0a3f092
Compare
Snapshot successfully published to
|
496e983
to
984c99c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
Can we also unblock this test as part of this PR?
|
5199f6e
to
c6322c7
Compare
c6322c7
to
1f056fe
Compare
1f056fe
to
930aed9
Compare
930aed9
to
0b0569c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #5447
Description
This change applies the change that was added in #3330 and ensures that we won't regress on this issue again by adding the relevant testing into functional and E2E testing. Hashing the resource quantity value as a string was missed with the changes were ported over and duplicated from the AWS provider struct in v1alpha1.
How was this change tested?
make presubmit
/karpenter snapshot
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.