feat: Add AssociatePublicIpAddress to EC2NodeClass

[myaser]

Fixes #2026

Description
Add an AssignPublicIpAddress field to the nodeclass

How was this change tested?
unit and integration tests were created;

Does this change impact docs?

• Yes, PR includes docs updates
• Yes, issue opened: #
• No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[netlify]

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	d7267aa
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/65c3e2afb652a80008da2889

[coveralls]

Pull Request Test Coverage Report for Build 7820524726

• 0 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.02%) to 82.633%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/launchtemplate/launchtemplate.go	1	83.64%

Totals
Change from base Build 7819962129:	0.02%
Covered Lines:	5015
Relevant Lines:	6069

---

💛 - Coveralls

[jmdeal]

/karpenter snapshot

[github-actions]

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-8f79f9dbc0a8792eb643d6bd24688929e36bd556.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

[jmdeal]

/karpenter snapshot

[github-actions]

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-cb7a7dd1e6b23d1de6b5f3186edbf2308d0a3871.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

[jmdeal]

Other than this piece of feedback this looks good to me! I'm definitely open to discussion on that point but I think it's reasonable to enable users to still disable public IPs in public subnets for EFA instances if they want. This is relevant for instance types with a single network card and thus a single EFA.

[myaser]

Other than this piece of feedback this looks good to me! I'm definitely open to discussion on that point but I think it's reasonable to enable users to still disable public IPs in public subnets for EFA instances if they want. This is relevant for instance types with a single network card and thus a single EFA.

thanks, would it be possible to add this piece of requirements iteratively? I do not think we are compromising the UX of developers with this PR, so we can consider this as the next step.

I am just afraid this is taking more and more time and we are in need of this feature, so incremental improvements would help here

[jmdeal]

Sure, we can include this in a follow-up PR. I do think it's important but it is a gap in the original EFA implementation. I'll take one more review pass since it's been a couple weeks since I've last looked and then this should be good to go.

[jmdeal]

/karpenter snapshot

[github-actions]

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-d027001b6c3a324d283946ad7e975dfa8123c1c9.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

[jmdeal]

/karpenter snapshot

[github-actions]

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-d7267aab9900b476a0fb0e65a1dc6f6d15444539.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

[myaser]

@jmdeal
what is the status now :) can we merge this?

[jmdeal]

Since I made a couple of small updates I can't (or at least shouldn't) approve, I've reached out to other members of the Karpenter team to give it a quick review. It looks good to me, this should be able to go in before the next release.

[jonathan-innis]

LGTM 🚀