Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step for tagging subnets #543

Merged
merged 7 commits into from
Jul 23, 2021
Merged

add step for tagging subnets #543

merged 7 commits into from
Jul 23, 2021

Conversation

geoffcline
Copy link
Contributor

Description of changes:
add step to add cluster name tags to subnet resources

SUBNET_IDS=$(aws cloudformation describe-stacks \
    --stack-name eksctl-${CLUSTER_NAME}-cluster \
    --query 'Stacks[].Outputs[?OutputKey==`SubnetsPrivate`].OutputValue' \
    --output text)

aws ec2 create-tags \
    --resources $(echo $SUBNET_IDS | tr ',' '\n') \
    --tags Key="kubernetes.io/cluster/${CLUSTER_NAME}",Value=

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jul 23, 2021

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 20f6366

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/60fb46ce66d71e000814b02c

😎 Browse the preview: https://deploy-preview-543--karpenter-docs-prod.netlify.app

Copy link
Contributor

@akestner akestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoed @ellistarn's changes as suggestions to make it easy to update

website/content/en/docs/getting-started/_index.md Outdated Show resolved Hide resolved
website/content/en/docs/getting-started/_index.md Outdated Show resolved Hide resolved
website/content/en/docs/getting-started/_index.md Outdated Show resolved Hide resolved
website/content/en/docs/getting-started/_index.md Outdated Show resolved Hide resolved
@geoffcline
Copy link
Contributor Author

Thanks! I appreciate the additional info, I was unclear on the impact of this step.

ellistarn
ellistarn previously approved these changes Jul 23, 2021
@ellistarn ellistarn merged commit 20d9a8a into aws:main Jul 23, 2021
ellistarn added a commit to ellistarn/karpenter-provider-aws that referenced this pull request Jul 26, 2021
* readd step for tagging subnets

* Update website/content/en/docs/getting-started/_index.md

Co-authored-by: Alex Kestner <[email protected]>

* Update website/content/en/docs/getting-started/_index.md

Co-authored-by: Alex Kestner <[email protected]>

* Apply suggestions from code review

Co-authored-by: Alex Kestner <[email protected]>

* Update website/content/en/docs/getting-started/_index.md

* Update website/content/en/docs/getting-started/_index.md

Co-authored-by: Alex Kestner <[email protected]>
Co-authored-by: Ellis Tarn <[email protected]>
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants