Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump kubernetes-sigs/karpenter to v0.33.1 #5359

Merged
merged 2 commits into from
Dec 19, 2023
Merged

deps: bump kubernetes-sigs/karpenter to v0.33.1 #5359

merged 2 commits into from
Dec 19, 2023

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Dec 18, 2023

Fixes #N/A

Description
Bumps kubernetes-sigs/karpenter to v0.33.1.

How was this change tested?
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner December 18, 2023 20:12
@jmdeal jmdeal requested a review from engedaam December 18, 2023 20:12
jmdeal
jmdeal commented Dec 18, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@coveralls
Copy link

coveralls commented Dec 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7254205857

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.45%
Totals Coverage Status
Change from base Build 7228919095: 0.02%
Covered Lines: 4914
Relevant Lines: 5960
💛 - Coveralls

jmdeal
jmdeal commented Dec 18, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jmdeal
jmdeal commented Dec 18, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-35ed05202cee9be6868108d819a05f7f7a6ffdb6.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

@jmdeal
Copy link
Contributor Author

jmdeal commented Dec 19, 2023

All E2E tests have passed 🎉 Holding until we're ready to do the upstream release, this can be merged once we replace the pseudo-tag with the v0.33.1.

@jmdeal
Copy link
Contributor Author

jmdeal commented Dec 19, 2023

Posting the link to the test results before replacing the pseudo-tag with the proper release tag. link

@jmdeal jmdeal changed the title [WIP] deps: bump kubernetes-sigs/karpenter deps: bump kubernetes-sigs/karpenter to v0.33.1 Dec 19, 2023
jonathan-innis
jonathan-innis approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 90eb276 into aws:release-v0.33.x Dec 19, 2023
8 checks passed
@chlunde chlunde mentioned this pull request Feb 1, 2024
Closed
3 tasks
@jmdeal jmdeal deleted the release-v0.33.1 branch May 9, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@engedaam engedaam Awaiting requested review from engedaam engedaam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmdeal @coveralls @jonathan-innis