Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify drift enablement in migration doc #5289

Merged
merged 12 commits into from
Dec 11, 2023
Merged

docs: Clarify drift enablement in migration doc #5289

merged 12 commits into from
Dec 11, 2023

Conversation

garvinp-stripe
Copy link
Contributor

@garvinp-stripe garvinp-stripe commented Dec 9, 2023 •
edited
Loading

Fixes #N/A

Description

  • Fix enabling drift in v1beta migration doc.
  • Fix link for awsnodetemplate

How was this change tested?
Tested the new links in the deploy preview

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@garvinp-stripe garvinp-stripe requested a review from a team as a code owner December 9, 2023 21:51
@netlify Netlify
Copy link

netlify bot commented Dec 9, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit e0755c8
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65775a154727810008a488b2
😎 Deploy Preview https://deploy-preview-5289--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@garvinp-stripe garvinp-stripe changed the title Add new subsection on enabling drift + Link to it from migration doc docs: Add new subsection on enabling drift + Link to it from migration doc Dec 9, 2023
@garvinp-stripe garvinp-stripe changed the title docs: Add new subsection on enabling drift + Link to it from migration doc docs: Clarify drift enablement in migration doc Dec 9, 2023
@coveralls
Copy link

coveralls commented Dec 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7172008910

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.489%
Totals Coverage Status
Change from base Build 7171959179: 0.0%
Covered Lines: 4918
Relevant Lines: 5962
💛 - Coveralls

njtran
njtran approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@garvinp-stripe
Copy link
Contributor Author

@njtran can you retrigger to tests?

@jonathan-innis jonathan-innis enabled auto-merge (squash) December 11, 2023 23:34
jonathan-innis
jonathan-innis approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 8708496 into aws:main Dec 11, 2023
12 checks passed
@garvinp-stripe garvinp-stripe deleted the migration-doc-update branch December 12, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@njtran njtran njtran approved these changes

@engedaam engedaam Awaiting requested review from engedaam engedaam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garvinp-stripe @coveralls @njtran @jonathan-innis