Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move build_info metric to kubernetes-sigs and bump #5281

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Dec 8, 2023

Fixes #N/A

Description

This moves the original PR for the #5213 for the build_info metric over to kuberntes-sigs by using the new version that leverages it.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b5d0340
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6572bced39fe4a000845438d

@jonathan-innis jonathan-innis changed the title chore: Move build_info metric to kubernetes-sigs and bump chore: Move build_info metric to kubernetes-sigs and bump Dec 8, 2023
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jonathan-innis jonathan-innis marked this pull request as ready for review December 8, 2023 06:07
@jonathan-innis jonathan-innis requested a review from a team as a code owner December 8, 2023 06:07
@jonathan-innis jonathan-innis requested a review from tzneal December 8, 2023 06:07
@jonathan-innis jonathan-innis enabled auto-merge (squash) December 8, 2023 06:07
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-b3ae49fa649fcf6fcf13c075104cca6eb563dbbf.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7138124369

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 82.489%

Totals Coverage Status
Change from base Build 7136787754: 0.01%
Covered Lines: 4918
Relevant Lines: 5962

💛 - Coveralls

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-b5d03400bf77105e7cb0472e0df8a90c1df85e6b.

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit b75e37e into aws:main Dec 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants