Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the build_info metric label naming and tests #5275

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Dec 8, 2023

Fixes #N/A

Description

This updates the build_info metric that was added in #5213 so that it uses commit as a label to match the logging. It also adds testing and fixes the break in make docgen for not having a subsystem

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner December 8, 2023 01:54
@jonathan-innis jonathan-innis requested a review from jmdeal December 8, 2023 01:54
Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit fe1baf3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65727909589bf8000814e47a
😎 Deploy Preview https://deploy-preview-5275--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Dec 8, 2023

Pull Request Test Coverage Report for Build 7136427344

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.478%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 7136265182: -0.02%
Covered Lines: 4919
Relevant Lines: 5964

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the update-build-info-metric branch from 22e55b5 to f6a1654 Compare December 8, 2023 01:56
@jonathan-innis jonathan-innis enabled auto-merge (squash) December 8, 2023 01:56
@jonathan-innis jonathan-innis force-pushed the update-build-info-metric branch from f6a1654 to fe1baf3 Compare December 8, 2023 02:01
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 99cfbaf into aws:main Dec 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants