Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove Service account annotation for Karpenter and Prometheus #5274

Merged
merged 1 commit into from
Dec 8, 2023
Merged

ci: Remove Service account annotation for Karpenter and Prometheus #5274

merged 1 commit into from
Dec 8, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 7, 2023

Fixes #N/A

Description

  • Remove Service account annotation for Karpenter and Prometheus
  • Add eks-auth:AssumeRoleForPodIdentity pod identity authentication

How was this change tested?

  • karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit dc0ddf2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65726d2f12b4590008104ac0

@engedaam engedaam force-pushed the remove-service-account branch 2 times, most recently from 9fe0cc6 to 8f9a13c Compare December 8, 2023 00:43
@engedaam engedaam marked this pull request as ready for review December 8, 2023 00:43
@engedaam engedaam requested a review from a team as a code owner December 8, 2023 00:43
@engedaam engedaam requested a review from ellistarn December 8, 2023 00:43
@coveralls
Copy link

coveralls commented Dec 8, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7136047131

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.478%
Totals Coverage Status
Change from base Build 7134358516: 0.0%
Covered Lines: 4919
Relevant Lines: 5964
💛 - Coveralls

@engedaam engedaam force-pushed the remove-service-account branch from 8f9a13c to 217f720 Compare December 8, 2023 01:06
@engedaam engedaam force-pushed the remove-service-account branch from 217f720 to dc0ddf2 Compare December 8, 2023 01:11
jonathan-innis
jonathan-innis approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Nice work

@engedaam engedaam enabled auto-merge (squash) December 8, 2023 01:14
@engedaam engedaam merged commit 075b3cd into aws:main Dec 8, 2023
12 checks passed
@engedaam engedaam deleted the remove-service-account branch December 8, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jonathan-innis