Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update karpenter-convert mod #5261

Merged

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 6, 2023

Fixes #N/A

Description

  • Update karpenter-convert to support converting CDL tags into selectors

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam force-pushed the update-karpenter-converter-tool branch 2 times, most recently from 9973b7a to a03d5bc Compare December 6, 2023 23:14
@coveralls
Copy link

coveralls commented Dec 6, 2023

Pull Request Test Coverage Report for Build 7122548663

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.387%

Totals Coverage Status
Change from base Build 7122303609: 0.0%
Covered Lines: 6179
Relevant Lines: 7500

💛 - Coveralls

@engedaam engedaam force-pushed the update-karpenter-converter-tool branch from a03d5bc to 8351297 Compare December 7, 2023 01:08
@engedaam engedaam marked this pull request as ready for review December 7, 2023 01:29
@engedaam engedaam requested a review from a team as a code owner December 7, 2023 01:29
@engedaam engedaam requested a review from bwagner5 December 7, 2023 01:29
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 3fe4479 into aws:release-v0.32.x Dec 7, 2023
8 checks passed
@engedaam engedaam deleted the update-karpenter-converter-tool branch December 8, 2023 01:44
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants