Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Caught another missing version reference #5260

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: Caught another missing version reference #5260

merged 1 commit into from
Dec 6, 2023

Conversation

ellistarn
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner December 6, 2023 22:31
@ellistarn ellistarn requested a review from jmdeal December 6, 2023 22:31
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit a6da933
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6570f64ed7cdb20008e7788e

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7121088685

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.472%
Totals Coverage Status
Change from base Build 7119455794: 0.0%
Covered Lines: 4917
Relevant Lines: 5962
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn enabled auto-merge (squash) December 6, 2023 22:35
@ellistarn ellistarn merged commit f73ccfa into aws:main Dec 6, 2023
12 checks passed
@ellistarn ellistarn deleted the vers branch December 6, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellistarn @coveralls @jonathan-innis