Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop karpenter-convert tool for v0.33 #5235

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Dec 5, 2023

Fixes #N/A

Description

This PR drops the karpenter-convert tool for the v0.33 release.

The tool can still be accessed on the v0.32 release branch: https://github.com/aws/karpenter/tree/release-v0.32.x/tools/karpenter-convert and can be installed to get the latest version through the following command

go install github.com/aws/karpenter/tools/karpenter-convert/cmd/[email protected]

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner December 5, 2023 18:13
Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d553dd6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/656f69d902f3490008a575dd

njtran
njtran previously approved these changes Dec 5, 2023
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's add in description with the description of where to find the tool that you included in the docs so that it's easier to find that information.

@jonathan-innis jonathan-innis merged commit d3c7c53 into aws:main Dec 5, 2023
11 checks passed
@jonathan-innis jonathan-innis deleted the drop-karpenter-convert branch December 5, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants