Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Drop Alpha Settings and Add Beta Defaults to Chart #5159

Merged
merged 10 commits into from
Nov 29, 2023
Merged

BREAKING CHANGE: Drop Alpha Settings and Add Beta Defaults to Chart #5159

merged 10 commits into from
Nov 29, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Nov 24, 2023 •
edited
Loading

Fixes #N/A

Description

This PR performs the following actions which are now supported by the beta version of Karpenter:

  1. Disable webhooks by default. If you were previously running Karpenter leveraging the webhooks on a version of K8s less than 1.25, you will now need to set --set webhook.enabled=true in the helm chart
  2. Moves the logging default to be info now. If you are interested in more verbose error logging, you will now need to set the --set logLevel=debug value in the helm chart.
  3. Updates the role permissions for the Karpenter role to reduce its permission scope since it's no longer using the webhook

This change also drops the settings.Settings struct now that this field is no longer supported in kubernetes-sigs/karpenter

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner November 24, 2023 19:21
@jonathan-innis jonathan-innis changed the title chore: Drop alpha settings chore: Drop alpha settings from chart Nov 24, 2023
@jonathan-innis jonathan-innis marked this pull request as draft November 24, 2023 19:21
@jonathan-innis jonathan-innis changed the title chore: Drop alpha settings from chart [DRAFT] chore: Drop alpha settings from chart Nov 24, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 24, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit f396159
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6567a5a7031b5d0008303dda

@jonathan-innis jonathan-innis force-pushed the drop-alpha-settings branch 24 times, most recently from 7871052 to eb841ec Compare November 28, 2023 04:22
jonathan-innis
jonathan-innis commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-ab3a8119ff563b42607e454edd524267f5b05331.

@jonathan-innis jonathan-innis changed the title [DRAFT] chore: Drop alpha settings from chart chore: Drop Alpha Settings and Add Beta Defaults to Chart Nov 29, 2023
@jonathan-innis jonathan-innis marked this pull request as ready for review November 29, 2023 01:15
@jonathan-innis jonathan-innis changed the title chore: Drop Alpha Settings and Add Beta Defaults to Chart BREAKING CHANGE: Drop Alpha Settings and Add Beta Defaults to Chart Nov 29, 2023
jonathan-innis
jonathan-innis commented Nov 29, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-c7d94a331d13fc5b0ad9dad10b439dab2cfded9f.

jmdeal
jmdeal previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

jmdeal
jmdeal previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

engedaam
engedaam previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis dismissed stale reviews from engedaam and jmdeal via f396159 November 29, 2023 20:57
@jonathan-innis jonathan-innis enabled auto-merge (squash) November 29, 2023 20:59
jmdeal
jmdeal approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 7c3a7aa into aws:main Nov 29, 2023
12 checks passed
@jonathan-innis jonathan-innis mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@engedaam engedaam engedaam left review comments

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @jmdeal @engedaam