Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flake for nodeclaim test #5037

Merged
merged 12 commits into from
Nov 7, 2023
Merged

test: fix flake for nodeclaim test #5037

merged 12 commits into from
Nov 7, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Nov 6, 2023

Fixes #N/A

Description
Add back instance profile creation for Garbage collection test.

How was this change tested?
make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner November 6, 2023 19:05
@njtran njtran requested a review from tzneal November 6, 2023 19:05
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 1fa140b
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/654a7f2772b93c0008cf0762

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@njtran njtran enabled auto-merge (squash) November 7, 2023 18:23
@njtran njtran merged commit db91c38 into aws:main Nov 7, 2023
jonathan-innis pushed a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request Nov 21, 2023
jonathan-innis pushed a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request Nov 21, 2023
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants