Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CEL Validation for NodeClaim Requirement #4895

Merged
merged 1 commit into from
Oct 24, 2023
Merged

feat: CEL Validation for NodeClaim Requirement #4895

merged 1 commit into from
Oct 24, 2023

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

  • make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner October 23, 2023 17:52
@engedaam engedaam requested a review from njtran October 23, 2023 17:52
@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4e16dbe
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/653717844b61e40008de5822

@engedaam engedaam force-pushed the nodeclaim_template_requirements_cel branch 13 times, most recently from 808832a to 1f4fb50 Compare October 24, 2023 00:15
jonathan-innis
jonathan-innis reviewed Oct 24, 2023
View reviewed changes
hack/validation/requirements.sh Outdated Show resolved Hide resolved
hack/validation/requirements.sh Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the nodeclaim_template_requirements_cel branch 4 times, most recently from 55d4a40 to e2621c2 Compare October 24, 2023 00:39
jonathan-innis
jonathan-innis previously approved these changes Oct 24, 2023
View reviewed changes
pkg/apis/v1beta1/nodepool_validation_cel_test.go Outdated Show resolved Hide resolved
pkg/apis/v1beta1/nodepool_validation_cel_test.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the nodeclaim_template_requirements_cel branch 3 times, most recently from fcfbaef to d6fa340 Compare October 24, 2023 00:49
@engedaam engedaam force-pushed the nodeclaim_template_requirements_cel branch from d6fa340 to 4e16dbe Compare October 24, 2023 01:01
jonathan-innis
jonathan-innis approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit f02ebff into aws:main Oct 24, 2023
11 checks passed
@engedaam engedaam deleted the nodeclaim_template_requirements_cel branch October 24, 2023 01:20
@midu-git midu-git mentioned this pull request Nov 9, 2023
Closed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
@engedaam @johngmyers
feat: CEL Validation for NodeClaim Requirement (aws#4895)
79389b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@njtran njtran Awaiting requested review from njtran njtran is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engedaam @jonathan-innis