-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getting started based on fargate #488
Conversation
@@ -103,17 +100,18 @@ kind: Provisioner | |||
metadata: | |||
name: default | |||
spec: | |||
ttlSeconds: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this just to show how people can configure it and for the cleanup section later to help people avoid costs.
I'm not sure why but I think it's cool to see a bunch of fargate nodes and instances running workloads 😃
|
--parameter-overrides ClusterName=${CLUSTER_NAME} | ||
|
||
# Add the karpenter node role to your aws-auth configmap, allowing nodes with this role to connect to the cluster. | ||
eksctl create iamidentitymapping \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
docs/aws/README.md
Outdated
--nodes-max 10 \ | ||
--managed \ | ||
--with-oidc | ||
curl -fsSL https://raw.githubusercontent.com/awslabs/karpenter/"${LATEST_KARPENTER_VERSION}"/docs/aws/eks-config.yaml \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this work
curl -fsSL https://raw.githubusercontent.com/awslabs/karpenter/$LATEST_KARPENTER_VERSION/docs/aws/eks-config.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until this is merged you'll have to change the curl command to cat ./docs/aws/eks-config.yaml
on this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or you should be able to
curl -fsSL https://raw.githubusercontent.com/awslabs/karpenter/7afb5fdc65373e96efe08edcb52837673cd5c9b6/docs/aws/eks-config.yaml
``` | ||
|
||
### Create a Cluster | ||
|
||
Create an EKS cluster | ||
Karpenter can run anywhere, including on self-managed node groups, [managed node groups](https://docs.aws.amazon.com/eks/latest/userguide/managed-node-groups.html), or [AWS Fargate](https://aws.amazon.com/fargate/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need another line here, "including other cloud providers"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be in the AWS guide? I would assume when we get support for other providers we'll have different guides for those environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -37,54 +38,47 @@ SUBNET_IDS=$(aws cloudformation describe-stacks \ | |||
--output text) | |||
|
|||
aws ec2 create-tags \ | |||
--resources $(echo $SUBNET_IDS | tr ',' '\n') \ | |||
--resources $(echo ${SUBNET_IDS//,/ }) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
ClusterName: | ||
Type: String | ||
Description: "EKS cluster name" | ||
Resources: | ||
KarpenterControllerRole: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now users are forced to install karpenter using eksctl (to create this role). Thoughts on alternatives?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the example we're only showing eksctl (and how easy it is) We should absolutely document how to do this manually and what the requirements are (as well how to customize it). That all seemed like out of scope for the getting started guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Description of changes:
This updates the AWS getting started guide to create an EKS cluster using fargate instead of a managed node group. It also simplifies some of the karpenter cloudformation by including a service account with the EKS config.
I ran through the setup a few times and this morning did it on a personal account to verify costs. For the cluster I provisioned this setup should be slightly cheaper. I'm waiting for my bill to give an exact estimate but based on what I tried it's$.0864 with fargate vs $ .096 with m5.large instance.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.