Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding CEL validation for the EC2NodeClass #4746

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Oct 3, 2023

Fixes #N/A

Description

How was this change tested?

  • make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit d0a9844
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/652dc953ca35480008e89332
😎 Deploy Preview https://deploy-preview-4746--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@engedaam engedaam force-pushed the cel_validation_v1bata1_ec2nodeclass branch 5 times, most recently from a7b2c57 to 54a57e4 Compare October 3, 2023 23:51
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the cel_validation_v1bata1_ec2nodeclass branch 14 times, most recently from 532cdc7 to 64fd05c Compare October 10, 2023 18:07
@engedaam engedaam marked this pull request as ready for review October 10, 2023 18:07
@engedaam engedaam requested a review from a team as a code owner October 10, 2023 18:07
@engedaam engedaam requested a review from tzneal October 10, 2023 18:08
@engedaam engedaam force-pushed the cel_validation_v1bata1_ec2nodeclass branch 6 times, most recently from 0caa329 to 8137403 Compare October 12, 2023 23:38
@engedaam engedaam force-pushed the cel_validation_v1bata1_ec2nodeclass branch 3 times, most recently from 5e232dc to ba4adf4 Compare October 13, 2023 20:21
@engedaam engedaam force-pushed the cel_validation_v1bata1_ec2nodeclass branch 9 times, most recently from e028ead to 6385c55 Compare October 16, 2023 18:01
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yaml Outdated Show resolved Hide resolved
pkg/apis/v1beta1/ec2nodeclass_validation_cel_test.go Outdated Show resolved Hide resolved
pkg/apis/v1beta1/ec2nodeclass_validation_cel_test.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the cel_validation_v1bata1_ec2nodeclass branch 6 times, most recently from 9953f69 to 37a19c1 Compare October 16, 2023 22:10
@engedaam engedaam force-pushed the cel_validation_v1bata1_ec2nodeclass branch from 37a19c1 to 9284db0 Compare October 16, 2023 23:37
@engedaam engedaam force-pushed the cel_validation_v1bata1_ec2nodeclass branch from 9284db0 to d0a9844 Compare October 16, 2023 23:37
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-d0a9844078da2257b7a57de7f06c901efbe12499.

@engedaam engedaam merged commit 4b56b1d into aws:main Oct 17, 2023
12 checks passed
@engedaam engedaam deleted the cel_validation_v1bata1_ec2nodeclass branch October 17, 2023 05:10
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants